Add custom domain config to sail share #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is possible to a number of Expose configuration values in your
.env
file that are passed through to Expose when runningsail share
.However although custom subdomain support is included it is not possible to use a custom domain unless appending manually to your share command eg
sail share --domain=mydomain.com
.This PR allows a custom domain to be set in your
.env
exactly the same as you auth token and other expose configuration items.