Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom domain config to sail share #531

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Add custom domain config to sail share #531

merged 1 commit into from
Jan 27, 2023

Conversation

mojowill
Copy link
Contributor

Currently it is possible to a number of Expose configuration values in your .env file that are passed through to Expose when running sail share.

However although custom subdomain support is included it is not possible to use a custom domain unless appending manually to your share command eg sail share --domain=mydomain.com.

This PR allows a custom domain to be set in your .env exactly the same as you auth token and other expose configuration items.

@taylorotwell taylorotwell merged commit 8c9d836 into laravel:1.x Jan 27, 2023
@mojowill mojowill deleted the patch-1 branch January 27, 2023 16:33
@mojowill
Copy link
Contributor Author

@taylorotwell Thanks!

I assumed everyone would be busy in Lisbon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants